Conversation
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: .go-version |
There was a problem hiding this comment.
Will this cause any issues if the golang-bump happens afterwards? Let's say current version is 1.22.7 and the upcoming one is 1.22.8, hence this step will point to 1.22.7 but the updatecli pipeline will move the version from 1.22.7 to 1.22.8
There was a problem hiding this comment.
Good question. It's better to install the new version of go.
There was a problem hiding this comment.
Hence, this change will not install the new version if that's the pre-req
There was a problem hiding this comment.
Updatecli can neither execute a specified target nor run a subset of targets. I came up with one solution that I don't like.
- run updatecli with
--commit false --push false. It applies the changes to the target files. - install go with GHA using updated
.go-version - run updatecli again without
--commit false --push falseand it pushes the changes.
Please check the updates. Do you have any ideas on how can we make it in one execution?
There was a problem hiding this comment.
First, can you explain the motivation for running go mod tidy? I have not seen the need to use it while running the same mechanism with other golang versions:
- [Automation] Bump Golang version to 1.22.7 #41018
- [Automation] Bump Golang version to 1.22.6 #40528
- [Automation] Bump Golang version to 1.21.12 #40114
Updatecli can neither execute a specified target nor run a subset of targets.
As far as I see there is a parameter called dependson, see https://www.updatecli.io/docs/core/target/#_parameters:
"dependson" allows to specify the order of execution of resources It accepts a list of rules like "(resourceType#)resourceId(:booleanOperator)" The resourceType is optional and can be one of "condition", "source" or "target"
v1v
left a comment
There was a problem hiding this comment.
Will this change also needed in bump-golang-7.17.yml?
|
Added the same for 7.17 |
| uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0 | ||
| with: | ||
| channel-id: '#ingest-notifications' | ||
| channel-id: "#ingest-notifications" |
|
This change affected by #41563? |
|
Closing as done in #41563 |
Proposed commit message
Performs
go mod tidyafter updating the go version in go.modChecklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs